Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log when show version modelName is an empty string #850

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gmuloc
Copy link
Collaborator

@gmuloc gmuloc commented Oct 3, 2024

Description

Fixes # (issue id)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have run pre-commit for code linting and typing (pre-commit run)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (tox -e testenv)

Copy link

sonarcloud bot commented Oct 3, 2024

Copy link

codspeed-hq bot commented Oct 3, 2024

CodSpeed Performance Report

Merging #850 will not alter performance

Comparing gmuloc:nice-failure-on-empty-modelName (f38f36e) with main (fc644a1)

Summary

✅ 4 untouched benchmarks

@gmuloc gmuloc changed the title Feat: Log when show version modelName is an empty string feat: Log when show version modelName is an empty string Oct 3, 2024
@gmuloc gmuloc requested a review from mtache October 4, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant