-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Redo the model for additional-paths in BGP #3730
Feat(eos_cli_config_gen): Redo the model for additional-paths in BGP #3730
Conversation
49ab207
to
1fc1c01
Compare
This will break existing deployments since you are changing an existing model in a non-backwards-compatible way. |
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
...rista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/defs_additional_paths.schema.yml
Outdated
Show resolved
Hide resolved
This changes are kept hold till AVD5.0 release. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR is stale because it has been open 30 days with no activity. The PR will be reviewed by a maintainer and may be closed |
035e27d
to
4233a04
Compare
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cd3b6b4
to
189f8cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the porting-guide for this breaking change
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/defs_additional_paths.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/defs_additional_paths.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
e05824a
to
9cfb032
Compare
Added required changes. |
...n-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/defs_bgp_additional_paths.schema.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Claus Holbech <[email protected]>
Co-authored-by: Claus Holbech <[email protected]>
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-bgp.j2
Outdated
Show resolved
Hide resolved
Many changes since this review. Please take another round.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Redo the model for additional-paths in BGP to reduce number of key-value pairs and avoid repeated use of block of code using defs.
Related Issue(s)
Fixes #3279
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Enhancing code by replacing multiple key-value pairs with boolean values with the help of valid_values key.
Using defs to avoid repeated use of a block of code.
How to test
Checklist
User Checklist
Repository Checklist