-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_validate_state): Added the validation for AVT path for static peers and role of device #4200
base: devel
Are you sure you want to change the base?
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4200
# Activate the virtual environment
source test-avd-pr-4200/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4188#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4188 --force
# Optional: Install AVD examples
cd test-avd-pr-4200
ansible-playbook arista.avd.install_examples |
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestavt.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestavt.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestavt.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestavt.py
Outdated
Show resolved
Hide resolved
…_modules/tests/avdtestavt.py Co-authored-by: Guillaume Mulocher <[email protected]>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Quality Gate passedIssues Measures |
Change Summary
Added the validation for AVT path for static peers and role of device.
Related Issue(s)
Fixes #4188
Component(s) name
arista.avd.eos_validate_state
Proposed changes
Added the testcase for to verify AVT path and role from ANTA.
How to test
Run the validation playbook on lab or run molecule
Checklist
User Checklist
Repository Checklist