Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Improve schema for redistributes_routes under address_family_ipv4_multicast, address_family_ipv6 and vrfs for router_bgp #4359

Merged
merged 25 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e565686
added valid values for redistribute routes
MaheshGSLAB Aug 12, 2024
ea23a5d
Merge branch 'devel' into todo-bgp
MaheshGSLAB Aug 13, 2024
d6bf9c2
updated porting guide
MaheshGSLAB Aug 14, 2024
b9703f6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 14, 2024
4b845fc
updated porting-guide
MaheshGSLAB Aug 14, 2024
61414ff
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 14, 2024
ee6d349
updated porting guide
MaheshGSLAB Aug 14, 2024
2adf481
Merge branch 'devel' into todo-bgp
MaheshGSLAB Aug 16, 2024
c3cb4b0
addressed comments
MaheshGSLAB Aug 16, 2024
716ec22
updated j2 and schema with isis levels
MaheshGSLAB Aug 21, 2024
ff3ba04
updated porting guide
MaheshGSLAB Aug 21, 2024
54663db
updated title in porting guide
MaheshGSLAB Aug 21, 2024
e362639
updated the schema for isis level
MaheshGSLAB Aug 21, 2024
b1f0e13
updated the schema
MaheshGSLAB Aug 22, 2024
86ce389
Merge branch 'devel' into todo-bgp
MaheshGSLAB Sep 20, 2024
796de53
updated schema for address_family_ipv4_multicast
MaheshGSLAB Sep 20, 2024
7a90e90
updated schema for redistribute routes
MaheshGSLAB Sep 24, 2024
f9d6b56
fix CI failure
MaheshGSLAB Sep 24, 2024
072847e
Merge branch 'devel' into todo-bgp
carlbuchmann Sep 27, 2024
fc48f82
added few more testcases
MaheshGSLAB Sep 30, 2024
46a1641
updated the logic for ospf and ospfv3
MaheshGSLAB Oct 1, 2024
afee617
updated the description
MaheshGSLAB Oct 1, 2024
3b80e62
updated the schema for vlan aware bundle
MaheshGSLAB Oct 1, 2024
119f30b
fix the j2 logic for include_leaked
MaheshGSLAB Oct 1, 2024
b7e8916
Merge branch 'devel' into todo-bgp
carlbuchmann Oct 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ansible_collections/arista/avd/docs/porting-guides/5.x.x.md
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,16 @@ As of AVD 5.0.0 "null" option for esp integrity and encryption has been replaced
+ encryption: disabled
```

### Added valid for data models `router_bgp.address_family_ipv4_multicast.redistribute_routes[].source_protocol`, `router_bgp.address_family_ipv6.redistribute_routes[].source_protocol`, and `router_bgp.vrf.redistribute_routes[].source_protocol`

Added valid for data models `router_bgp.address_family_ipv4_multicast.redistribute_routes[].source_protocol`, `router_bgp.address_family_ipv6.redistribute_routes[].source_protocol`, and `router_bgp.vrf.redistribute_routes[].source_protocol` to restrict the source protocol of redistribute routes in EOS configuration.
MaheshGSLAB marked this conversation as resolved.
Show resolved Hide resolved

| Model | Valid Values |
| ----- | ------------ |
| router_bgp.address_family_ipv4_multicast.redistribute_routes[].source_protocol | attached-host, connected, isis, ospf, ospfv3, static |
| router_bgp.address_family_ipv6.redistribute_routes[].source_protocol | attached-host, bgp, connected, dhcp, dynamic, isis, ospfv3, static, user |
| router_bgp.vrf.redistribute_routes[].source_protocol | attached-host, bgp, connected, dynamic, isis, ospf, ospfv3, rip, static, user |

### Removal of deprecated data models

The following data model keys have been removed from `eos_cli_config_gen` in v5.0.0.
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -1484,14 +1484,13 @@ keys:
keys:
source_protocol:
type: str
# TODO AVD5.0: Add valid values and ensure we cover all options.
# valid_values:
# - "attached-host"
# - "connected"
# - "isis"
# - "ospf"
# - "ospfv3"
# - "static"
valid_values:
- attached-host
- connected
- isis
- ospf
- ospfv3
- static
route_map:
type: str
include_leaked:
Expand Down Expand Up @@ -1646,17 +1645,16 @@ keys:
keys:
source_protocol:
type: str
# TODO AVD5.0: Add valid values and ensure we cover all options.
ClausHolbechArista marked this conversation as resolved.
Show resolved Hide resolved
# valid_values:
# - "attached-host"
# - "bgp"
# - "connected"
# - "dhcp"
# - "dynamic"
# - "isis"
# - "ospfv3"
# - "static"
# - "user"
valid_values:
- attached-host
- bgp
- connected
- dhcp
- dynamic
- isis
- ospfv3
- static
- user
route_map:
type: str
include_leaked:
Expand Down Expand Up @@ -2693,18 +2691,17 @@ keys:
keys:
source_protocol:
type: str
# TODO AVD5.0: Add valid values and ensure we cover all options.
# valid_values:
# - "attached-host"
# - "bgp"
# - "connected"
# - "dynamic"
# - "isis"
# - "ospf"
# - "ospfv3"
# - "rip"
# - "static"
# - "user"
valid_values:
- attached-host
- bgp
- connected
- dynamic
- isis
- ospf
- ospfv3
- rip
- static
- user
route_map:
type: str
include_leaked:
Expand Down
Loading