-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Changed the redistribute routes data model #4550
base: devel
Are you sure you want to change the base?
Refactor(eos_cli_config_gen): Changed the redistribute routes data model #4550
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4550
# Activate the virtual environment
source test-avd-pr-4550/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@redistribute-cli-gen#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,redistribute-cli-gen --force
# Optional: Install AVD examples
cd test-avd-pr-4550
ansible-playbook arista.avd.install_examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the porting-guide as well.
redistribute connected rcf VRF_AFIPV6_RCF_CONNECTED() | ||
redistribute isis include leaked | ||
redistribute ospfv3 match internal include leaked | ||
redistribute ospfv3 match external | ||
redistribute ospfv3 match nssa-external | ||
redistribute static route-map VRF_AFIPV6_RM_STATIC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nasty bug you found there. I would appreciate if you could put this in a separate fix PR. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised PR 4552
Quality Gate passedIssues Measures |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Change Summary
Changed the redistribute routes data model from list of dict(redistribute_routes) to dict of dict(redistribute).
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Deprecating old redistribute_routes data model and adding new dict of dict redistribute data model
How to test
Run the molecule
Checklist
User Checklist
Repository Checklist