Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Fix wrong indentation of config for redistribute routes in router_bgp.vrfs[].address_family_ipv6 #4552

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB commented Oct 4, 2024

Change Summary

Fix wrong indentation of config for redistribute routes in router_bgp.vrfs[].address_family_ipv6.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Fix wrong indentation of config for redistribute routes in router_bgp.vrfs[].address_family_ipv6.

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB added this to the v5.0.0 milestone Oct 4, 2024
@MaheshGSLAB MaheshGSLAB self-assigned this Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4552
# Activate the virtual environment
source test-avd-pr-4552/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@bgp-indent-fix#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,bgp-indent-fix --force
# Optional: Install AVD examples
cd test-avd-pr-4552
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 4, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review October 4, 2024 11:45
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners October 4, 2024 11:45
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Fix the indent issue for redistribute routes in vrf.address_family_ipv6 Fix(eos_cli_config_gen): Fix wrong indentation of config for redistribute routes in vrf.address_family_ipv6 Oct 4, 2024
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Fix wrong indentation of config for redistribute routes in vrf.address_family_ipv6 Fix(eos_cli_config_gen): Fix wrong indentation of config for redistribute routes in router_bgp.vrfs[].address_family_ipv6 Oct 4, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching and fixing this.

Copy link

sonarcloud bot commented Oct 4, 2024

@ClausHolbechArista ClausHolbechArista merged commit cb144b5 into aristanetworks:devel Oct 4, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants