Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test(eos_cli_config_gen): Improve test coverage part 1 #4781

Merged
merged 33 commits into from
Jan 23, 2025
Merged

Test(eos_cli_config_gen): Improve test coverage part 1 #4781

merged 33 commits into from
Jan 23, 2025

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Dec 4, 2024 •
edited
Loading

Change Summary

Improve test coverage for below templates:

Template Current Coverage %
doc/mac-security 96
doc/qos 96
eos/daemon-terminattr.j2 99
doc/tap-aggregation.j2 95
doc/mac-address-table-notification.j2 98
ipv6-dhcp-relay.j2 94
eos/monitor-telemetry-postcard-policy.j2 96
eos/interface-defaults.j2 97
doc/mcs-client.j2 94
eos/mcs-client 96
eos/queue-monitor-streaming.j2 98
eos/lldp.j2 88
doc/logging.j2 98
eos/priority-flow-control.j2 100
monitor-sessions.j2 100
eos/ptp.j2 94
eos/monitor_layer1.j2 100
eos/switchport_port_security 97
eos/tcam_profile 98
doc/router_l2_vpn 98
eos/router_msdp 96
eos/router_bgp 91
doc/monitor-sessions 99
doc/management-ssh 99
doc/sflow 96
doc/cvx Need to update
doc/stun 94
doc/service-routing-configuration-bgp 97
doc/port-channel-interfaces 90
doc/ipv6-dhcp-relay 95
doc/router-multicast 98
eos/ipv6-dhcp-relay 94

Related Issue(s)

Fixes #https://github.com/aristanetworks/avd-internal/issues/171

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4781
# Activate the virtual environment
source test-avd-pr-4781/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@coverage-part-1#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,coverage-part-1 --force
# Optional: Install AVD examples
cd test-avd-pr-4781
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 4, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Refactor(eos_cli_config_gen): Improve test coverage part 1 CI(eos_cli_config_gen): Improve test coverage part 1 Dec 4, 2024
@MaheshGSLAB MaheshGSLAB changed the title CI(eos_cli_config_gen): Improve test coverage part 1 Test(eos_cli_config_gen): Improve test coverage part 1 Dec 6, 2024
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Dec 9, 2024
MaheshGSLAB
MaheshGSLAB reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the coverage for below template which are still below 80%

documentation/community-lists.j2
documentation/router-multicast.j2

@laxmikantchintakindi laxmikantchintakindi force-pushed the coverage-part-1 branch 3 times, most recently from a0712c4 to 774dbb4 Compare December 12, 2024 12:01
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 16, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 17, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Dec 18, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Dec 23, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

MaheshGSLAB
MaheshGSLAB reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some template which has good coverage percentage but there are few missing tests. You can check the CI for coverage and check for eos_cli_config_gen template for which missing tests are none zero.

...ctions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host3/router-multicast.yml Outdated Show resolved Hide resolved
@MaheshGSLAB
Copy link
Contributor

There are some template which has good coverage percentage but there are few missing tests. You can check the CI for coverage and check for eos_cli_config_gen template for which missing tests are none zero.

Discussed with @gmuloc and decided to raise new PR to address all missing tests.

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review January 20, 2025 07:41
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners January 20, 2025 07:41
gmuloc
gmuloc reviewed Jan 20, 2025
View reviewed changes
python-avd/tests/pyavd/schema/data_merging_schema_class.py Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/lldp.schema.yml Show resolved Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/lldp.yml Outdated Show resolved Hide resolved
...ble_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/logging.yml Show resolved Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host2/cvx.yml Show resolved Hide resolved
...ions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host2/interface-defaults.yml Outdated Show resolved Hide resolved
...llections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host2/router-l2-vpn.yml Outdated Show resolved Hide resolved
...llections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host2/router-l2-vpn.yml Outdated Show resolved Hide resolved
...ections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host2/tap-aggregation.yml Show resolved Hide resolved
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft January 21, 2025 04:41
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review January 21, 2025 06:53
@github-actions github-actions bot added the state: conflict PR with conflict label Jan 22, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

ClausHolbechArista and others added 6 commits January 23, 2025 14:07
@ClausHolbechArista
Refactor(plugins): Add support for default_value to natural_sort (ari…
eaca5bd 
…stanetworks#4901)
@kpbush30 @pre-commit-ci
@ClausHolbechArista @gmuloc
Feat(eos_designs): Add platform match criteria for network_ports (ari…
606ebdb 
…stanetworks#4798)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Claus Holbech <[email protected]>
Co-authored-by: Guillaume Mulocher <[email protected]>
@MaheshGSLAB @gmuloc
Refactor(eos_cli_config_gen): Updated hash_algorithm and `authenti…
12926d6 
…cation key` as required key in ntp schema (aristanetworks#4876)

Co-authored-by: Mahesh Kumar <[email protected]>
Co-authored-by: Guillaume Mulocher <[email protected]>
@ClausHolbechArista
Fix(eos_designs)!: Correct Loopback prefixes in PL-LOOPBACKS-EVPN-OVE…
a30740d 
…RLAY prefix-list (aristanetworks#4915)
@ccsnw
Feat(eos_cli_config_gen): Add support for Next Hop Self Source Interf…
097e047 
…ace to EVPN Peer Groups (aristanetworks#4903)
Merge branch 'devel' into coverage-part-1
6f9f623
@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 23, 2025
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@gmuloc gmuloc merged commit 6fa781b into aristanetworks:devel Jan 23, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista left review comments

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

@gmuloc gmuloc gmuloc approved these changes

@Vibhu-gslab Vibhu-gslab Awaiting requested review from Vibhu-gslab

@Shivani-gslab Shivani-gslab Awaiting requested review from Shivani-gslab

@alexeygorbunov alexeygorbunov Awaiting requested review from alexeygorbunov

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
rn: Test(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@laxmikantchintakindi @MaheshGSLAB @gmuloc @ClausHolbechArista @kpbush30 @ccsnw