Feat(eos_cli_config_gen): Additional interface TE options #4823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4823
# Activate the virtual environment
source test-avd-pr-4823/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@feat/eos_cli_config_gen/interface-additional-te-knobs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,feat/eos_cli_config_gen/interface-additional-te-knobs --force
# Optional: Install AVD examples
cd test-avd-pr-4823
ansible-playbook arista.avd.install_examples |
ClausHolbechArista
requested changes
Jan 6, 2025
Comment on lines
2236
to
+2241
| ip address 100.64.127.4/31 | ||
| traffic-engineering bandwidth 100 mbps | ||
| traffic-engineering administrative-group 4,7-100,testgrp | ||
| traffic-engineering srlg 16 | ||
| traffic-engineering metric 2 | ||
| traffic-engineering min-delay static 2 milliseconds |
There was a problem hiding this comment.
This interface has no traffic-engineering command. Is that possible/valid? Is there a difference in EOS behavior having or not having that command? (If it is possible to not have it, I would expect it to be the "enabler" for the whole feature, and if so, we should keep the enabled flag in the doc table and set it properly depending on this.
We should also add a TODO for AVD 6.0.0 to set the enabled key as required in the schema.
Comment on lines
+2255
to
+2257
| unit: | ||
| type: str | ||
| valid_values: |
There was a problem hiding this comment.
Suggested change
| unit: | |
| type: str | |
| valid_values: | |
| unit: | |
| type: str | |
| required: true | |
| valid_values: |
Comment on lines
+2250
to
+2251
| type: int | ||
| convert_types: |
There was a problem hiding this comment.
Suggested change
| type: int | |
| convert_types: | |
| type: int | |
| required: true | |
| convert_types: |
Comment on lines
+2235
to
+2236
| type: int | ||
| convert_types: |
There was a problem hiding this comment.
Suggested change
| type: int | |
| convert_types: | |
| type: int | |
| required: true | |
| convert_types: |
Comment on lines
+2241
to
+2242
| type: str | ||
| valid_values: |
There was a problem hiding this comment.
Suggested change
| type: str | |
| valid_values: | |
| type: str | |
| required: true | |
| valid_values: |
Comment on lines
+1432
to
+1433
| type: int | ||
| convert_types: |
There was a problem hiding this comment.
Suggested change
| type: int | |
| convert_types: | |
| type: int | |
| required: true | |
| convert_types: |
Comment on lines
+1438
to
+1439
| type: str | ||
| valid_values: |
There was a problem hiding this comment.
Suggested change
| type: str | |
| valid_values: | |
| type: str | |
| required: true | |
| valid_values: |
Comment on lines
+1417
to
+1418
| type: int | ||
| convert_types: |
There was a problem hiding this comment.
Suggested change
| type: int | |
| convert_types: | |
| type: int | |
| required: true | |
| convert_types: |
Comment on lines
+1423
to
+1424
| type: str | ||
| valid_values: |
There was a problem hiding this comment.
Suggested change
| type: str | |
| valid_values: | |
| type: str | |
| required: true | |
| valid_values: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Implements additional interface TE options.
Also removes unnecessary doc template column added in #4754 for traffic_engineering.enabled which is already implied by the interface being added to the table (single criteria for appending to the list of interfaces is traffic_engineering.enabled == true). This would just be a column of all True values.
Related Issue(s)
Fixes part of #https://github.com/aristanetworks/avd-internal/issues/149
Component(s) name
arista.avd.eos_cli_config_genProposed changes
How to test
Tested with molecule and on device.
Checklist
Repository Checklist