-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add missing schemas for eos_designs #4840
Open
Vibhu-gslab
wants to merge
9
commits into
aristanetworks:devel
Choose a base branch
from
Vibhu-gslab:missing_schemas_4746
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat(eos_designs): Add missing schemas for eos_designs #4840
Vibhu-gslab
wants to merge
9
commits into
aristanetworks:devel
from
Vibhu-gslab:missing_schemas_4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4840
# Activate the virtual environment
source test-avd-pr-4840/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@missing_schemas_4746#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,missing_schemas_4746 --force
# Optional: Install AVD examples
cd test-avd-pr-4840
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Dec 20, 2024
Vibhu-gslab
force-pushed
the
missing_schemas_4746
branch
from
December 21, 2024 10:34
67728de
to
e9f652d
Compare
python-avd/pyavd/_eos_designs/schema/schema_fragments/event_monitor.schema.yml
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
missing_schemas_4746
branch
from
January 3, 2025 10:22
be4cd5e
to
1043e6d
Compare
ClausHolbechArista
requested changes
Jan 6, 2025
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/base/__init__.py
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
missing_schemas_4746
branch
from
January 6, 2025 06:54
76b8cfa
to
ebfd0b8
Compare
Vibhu-gslab
force-pushed
the
missing_schemas_4746
branch
from
January 6, 2025 08:52
76fd8c3
to
79109b4
Compare
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/host_vars/DC1-BL1A.yml
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
missing_schemas_4746
branch
from
January 7, 2025 09:31
79109b4
to
1461833
Compare
for more information, see https://pre-commit.ci
Co-authored-by: Claus Holbech <[email protected]>
Vibhu-gslab
force-pushed
the
missing_schemas_4746
branch
from
January 8, 2025 04:58
20de2ac
to
ce37e79
Compare
MaheshGSLAB
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gmuloc
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add schemas with 1:1 models from the eos_cli_config_gen schema:
Related Issue(s)
Fixes #4746
Component(s) name
arista.avd.eos_designs
Proposed changes
Added schemas in eos_designs and modified the required code.
Checklist
Repository Checklist