Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add missing schemas for eos_designs #4840

Open
wants to merge 9 commits into
base: devel
Choose a base branch
from

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Add schemas with 1:1 models from the eos_cli_config_gen schema:

  1. event_monitor
  2. load_interval
  3. service_unsupported_transceiver
  4. queue_monitor_streaming

Related Issue(s)

Fixes #4746

Component(s) name

arista.avd.eos_designs

Proposed changes

Added schemas in eos_designs and modified the required code.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Dec 20, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4840
# Activate the virtual environment
source test-avd-pr-4840/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@missing_schemas_4746#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,missing_schemas_4746 --force
# Optional: Install AVD examples
cd test-avd-pr-4840
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Dec 20, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review December 26, 2024 06:38
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners December 26, 2024 06:38
@Vibhu-gslab Vibhu-gslab force-pushed the missing_schemas_4746 branch from be4cd5e to 1043e6d Compare January 3, 2025 10:22
@Vibhu-gslab Vibhu-gslab marked this pull request as draft January 6, 2025 06:50
@Vibhu-gslab Vibhu-gslab force-pushed the missing_schemas_4746 branch from 76b8cfa to ebfd0b8 Compare January 6, 2025 06:54
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review January 6, 2025 08:41
@Vibhu-gslab Vibhu-gslab force-pushed the missing_schemas_4746 branch from 76fd8c3 to 79109b4 Compare January 6, 2025 08:52
@Vibhu-gslab Vibhu-gslab force-pushed the missing_schemas_4746 branch from 79109b4 to 1461833 Compare January 7, 2025 09:31
@Vibhu-gslab Vibhu-gslab marked this pull request as draft January 7, 2025 09:31
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review January 7, 2025 11:03
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing schemas for eos_designs
5 participants