Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts #4853

Merged
merged 9 commits into from
Jan 13, 2025

Conversation

ctyrider
Copy link
Contributor

@ctyrider ctyrider commented Jan 3, 2025

Change Summary

Add support for "icmp echo size ..." CLI syntax, under Monitor Connectivity hosts:

monitor connectivity
   host <HOST-NAME>
      icmp echo size <36-18024>
   vrf <VRF-NAME>
      host <HOST-NAME>
         icmp echo size <36-18024>

Related Issue(s)

Fixes #4848

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

New icmp_echo_size variable in eos_cli_config_gen:

monitor_connectivity:
  hosts:
     - name: <str; required; unique>
       icmp_echo_size: <int>
  vrfs:
     - name: <str; required; unique>
	   hosts:
             - name: <str; required; unique>
               icmp_echo_size: <int>

How to test

Molecule test pending

Checklist

User Checklist

  • N/A

Repository Checklist

  • [x ] My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ctyrider ctyrider requested review from a team as code owners January 3, 2025 18:17
Copy link

github-actions bot commented Jan 3, 2025

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4853
# Activate the virtual environment
source test-avd-pr-4853/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ctyrider/avd.git@issue4848#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ctyrider/avd.git#/ansible_collections/arista/avd/,issue4848 --force
# Optional: Install AVD examples
cd test-avd-pr-4853
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jan 7, 2025
@ctyrider ctyrider marked this pull request as ready for review January 7, 2025 15:23
@ctyrider ctyrider changed the title Feat (eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts Feat(eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts Jan 7, 2025
@ctyrider
Copy link
Contributor Author

ctyrider commented Jan 7, 2025

Ready to merge

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this PR - couple of comments

@gmuloc gmuloc requested a review from a team January 10, 2025 16:21
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laxmikantchintakindi
Copy link
Contributor

LGTM.

@gmuloc gmuloc merged commit f2b2ad1 into aristanetworks:devel Jan 13, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat (eos_cli_config_gen): Add ICMP echo size for Monitor Connectivity hosts
4 participants