Barney image changes for devel workflow #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajith-arista
force-pushed
the
aajith-eext-devworkflow
branch
2 times, most recently
from
58b61f1
to
c131041
Compare
aajith-arista
force-pushed
the
aajith-eext-devworkflow
branch
from
c131041
to
eb3cbbb
Compare
aajith-arista
force-pushed
the
aajith-eext-update-snapshots
branch
from
6854598
to
778d919
Compare
Separate out bootstrap code in barney.yaml to three parts in three different scripts: 1. Extract(boostrap/extract/extract.bash): Extracting bootstrap image from the tarball. 2. Setup dnf configuration(bootstrap/eext-repos/generate.bash): dnf configuration for both base image bootstrap and for install within base-image is done by this stage. 3. Install rpms(bootstrap/install-rpms/install-rpms.bash): The old install-rpms script is now reading rpms to be installed from the source files rpms-common and rpms-<conf> in the bootstrap/install-rpms directory. Also added a base-image-devel ref to be used by developers for interactive workflow.
aajith-arista
force-pushed
the
aajith-eext-devworkflow
branch
from
eb3cbbb
to
a056dcf
Compare
Merged
Using Snaipe's new bfg feature that allows file inlining to make the bootstrap, base image build and eext builds more bsy cache aware. Roll-With: barney.ci/barneyfile#203a8fea892dbd8d9058c7a9fce98d974f8ea99b
The go generator would pull in the current repo's commit hash into the snapshot hash. Instead, we'll running go build ourselves on a floor with the go toolchain and modules already present. We also map in the subset of sources needed to build the eext static binary. .%go/modules would have sufficed if not for the fact that it also pulls in all sources to do go mod tidy. So we just enable the network and forego any benefit from the go generator module cache.
aajith-arista
force-pushed
the
aajith-eext-devworkflow
branch
from
cb1f5fa
to
c9aa0e5
Compare
manith-arista
previously approved these changes
Sep 23, 2024
manith-arista
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR achieves two things: