Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug average in fate() #629

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Debug average in fate() #629

merged 1 commit into from
Dec 10, 2023

Conversation

Sichao25
Copy link
Collaborator

@Sichao25 Sichao25 commented Dec 5, 2023

Bug description:

  • The average option is disabled in the fate().
  • It doesn't distinguish the "origin" and "trajectory mode" as described in the docstring.

@codecov-commenter
Copy link

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e87f702) 22.17% compared to head (eb28841) 22.17%.

Files Patch % Lines
dynamo/prediction/fate.py 0.00% 7 Missing ⚠️
dynamo/tools/utils.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #629   +/-   ##
=======================================
  Coverage   22.17%   22.17%           
=======================================
  Files         166      166           
  Lines       28032    28028    -4     
=======================================
  Hits         6215     6215           
+ Misses      21817    21813    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sichao25 Sichao25 marked this pull request as ready for review December 5, 2023 19:25
@Xiaojieqiu Xiaojieqiu merged commit b2727f9 into aristoteleo:master Dec 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants