Replaced all types that are either missing or deprecated in Python3 with suitable alternatives that are still compatible with Python2. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arizvisa
commented
Nov 26, 2020
arizvisa
force-pushed
the
GH-76.warning
branch
from
0159119 to
6e8cccf
Compare
arizvisa
force-pushed
the
GH-76.types
branch
from
94f2ad1 to
b32e5be
Compare
arizvisa
force-pushed
the
GH-76.warning
branch
from
6e8cccf to
ac13d73
Compare
arizvisa
force-pushed
the
GH-76.warning
branch
from
ac13d73 to
8731dd2
Compare
arizvisa
force-pushed
the
GH-76.warning
branch
from
8731dd2 to
884bb79
Compare
arizvisa
force-pushed
the
GH-76.warning
branch
from
884bb79 to
f9de246
Compare
arizvisa
force-pushed
the
GH-76.types
branch
2 times, most recently
from
cba2d10 to
9a68f72
Compare
arizvisa
force-pushed
the
GH-76.warning
branch
from
763cebd to
8c07de8
Compare
arizvisa
force-pushed
the
GH-76.warning
branch
from
8c07de8 to
988c02e
Compare
…stead use the `six.string_types` tuple for Python3 compatibility.
…tead use the `six.string_types` tuple for Python3 compatibility.
…nstead use the `six.string_types` tuple for Python3 compatibility.
… instead use the `six.string_types` tuple for Python3 compatibility.
… instead use the `six.string_types` tuple for Python3 compatibility.
…stead use the `six.string_types` tuple for Python3 compatibility.
…to instead use the `six.string_types` tuple for Python3 compatibility.
…nstead use the `six.string_types` tuple for Python3 compatibility.
…ead use the `six.string_types` tuple for Python3 compatibility.
…use the `six.string_types` tuple for Python3 compatibility.
… the module as it's been removed in Python3.
… module as it's been removed in Python3.
…odule as it's been removed in Python3.
…he module as it's been removed in Python3.
…module as it's been removed in Python3.
…module as it's been removed in Python3.
…missing in Python3 with `builtins.type`.
arizvisa
force-pushed
the
GH-76.types
branch
from
947fbb7 to
ecb2af2
Compare
…nce integers defined with `int` are the exact same thing.
arizvisa
commented
Dec 12, 2020
|
Switching the merge target to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3 removes types from the
typesmodule liketypes.NoneTypeandtypes.TypeType. This PR replacestypes.NoneTypewithNone.__class__, andtypes.TypeTypewithbuiltins.type. Thebasestringbase class is also removed as there is now only onestrclass to rule them all. In order to retain Python2 compatibility, this class is replaced withsix.string_types.This PR is the third part of the fix for issue #76, and is dependant on PR #81.