Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Basic protection against concurrency issues #259

Closed
wants to merge 1 commit into from

Conversation

KyleMaas
Copy link
Collaborator

Basic protection against concurrency issues. See #139. Uses a localStorage-based mutex which times out in case a tab dies on us. Adds a bunch of extra checks throughout the codebase to try to gracefully handle a locked SSB.

Also fixes:

  • Fix error where clicking Refresh when you didn't have any messages would error out.
  • Fix missing getProfileNameAsync in Private.

Fix error where clicking Refresh when you didn't have any messages would error out.

Fix missing getProfileNameAsync in Private.
@arj03
Copy link
Owner

arj03 commented Feb 23, 2021

This is really exciting! I'll be in a call with mix soon so don't have time to properly review this, and it needs because it's a quite big change. Is it ok if I create a branch with some changes while I review it? Have some ideas to make this a bit simpler maybe. Also if you create your branches in this repo instead of KyleMass, then it should be easier to have that kind of workflow.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 23, 2021 via email

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Feb 23, 2021 via email

@KyleMaas
Copy link
Collaborator Author

Moved to #260.

@KyleMaas KyleMaas closed this Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants