Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to use custom signing scheme and multiple keys in vtxo tree signatures #422

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions api-spec/openapi/swagger/ark/v1/service.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,20 @@
}
}
},
"v1Musig2": {
"type": "object",
"properties": {
"cosignersPublicKeys": {
"type": "array",
"items": {
"type": "string"
}
},
"signingAll": {
"type": "boolean"
}
}
},
"v1Node": {
"type": "object",
"properties": {
Expand Down Expand Up @@ -685,9 +699,6 @@
"$ref": "#/definitions/v1Input"
}
},
"ephemeralPubkey": {
"type": "string"
},
"notes": {
"type": "array",
"items": {
Expand Down Expand Up @@ -717,6 +728,9 @@
"$ref": "#/definitions/v1Output"
},
"description": "List of receivers for to convert to leaves in the next VTXO tree."
},
"musig2": {
"$ref": "#/definitions/v1Musig2"
}
}
},
Expand Down
9 changes: 7 additions & 2 deletions api-spec/protobuf/ark/v1/service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -120,17 +120,22 @@ message GetBoardingAddressResponse {

message RegisterInputsForNextRoundRequest {
repeated Input inputs = 1;
optional string ephemeral_pubkey = 2;
repeated string notes = 3;
repeated string notes = 2;
}
message RegisterInputsForNextRoundResponse {
string request_id = 1;
}

message Musig2 {
repeated string cosigners_public_keys = 1;
bool signing_all = 2;
}

message RegisterOutputsForNextRoundRequest {
string request_id = 1;
// List of receivers for to convert to leaves in the next VTXO tree.
repeated Output outputs = 2;
optional Musig2 musig2 = 3;
}
message RegisterOutputsForNextRoundResponse {}

Expand Down
Loading