Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README, added --retain-traffic-data to cluster-destroy #159

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

chelma
Copy link
Collaborator

@chelma chelma commented Jan 19, 2024

Description

  • A couple quick fixes per user feedback.
  • The new --retain-traffic-data flag works the same way as the old default behavior of cluster-destroy; I just added a check that they provided either that flag or --destroy-everything to make the choice explicit and obvious.

Tasks

Testing

  • Tested the new option locally against my AWS account:
(.venv) chelma@3c22fba4e266 aws-aio % ./manage_arkime.py --region us-east-1 cluster-destroy --name MyCluster
2024-01-19 15:02:13 - Debug-level logs save to file: /Users/chelma/workspace/Arkime/aws-aio/manage_arkime/manage_arkime.log
2024-01-19 15:02:13 - Using AWS Credential Profile: None
2024-01-19 15:02:13 - Using AWS Region: us-east-1
2024-01-19 15:02:13 - You must specify either --destroy-everything or --retain-traffic-data
2024-01-19 15:02:13 - Aborting...

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@chelma chelma requested a review from awick January 19, 2024 21:07
@chelma chelma merged commit 6c70ed4 into main Jan 22, 2024
5 checks passed
@chelma chelma deleted the quick-fixes branch January 22, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants