Scheduler: refactor nodedb stats #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
robertdavidsmith
commented
Jan 24, 2025
•
robertdavidsmith
commented
- Method that updates "statistics" is misleadingly named, and should not be public
- Rename it
- Modify tests to use public method
- Remove lock, it's not needed, nodedb is not shared by multiple threads
Signed-off-by: Robert Smith <[email protected]>
Signed-off-by: Robert Smith <[email protected]>
d80tb7
approved these changes
Jan 24, 2025
richscott
pushed a commit
to richscott/armada
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Robert Smith <[email protected]> Signed-off-by: Rich Scott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.