Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Docker Build Compilation & Enable ARM64 Platform Support #20

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

SuperKali
Copy link
Member

@SuperKali SuperKali commented Feb 17, 2025

This pull request addresses the following:

  • Docker Build Compilation: Resolves issues encountered during the Docker build process to ensure a smooth and error-free compilation.
  • ARM64 Support: Introduces modifications to support the ARM64 architecture, allowing our build process to be executed successfully on ARM-based systems.
  • Bump versioning: Updated upload-artifact to v4.6.0 in the workflow configuration.

@igorpecovnik igorpecovnik requested a review from efectn February 17, 2025 11:27
@@ -3,7 +3,7 @@ FROM golang:alpine AS builder
WORKDIR /src

# Copy go mod and project files
COPY go.* .
COPY go.* ./
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Does this occur build failure? It was working with no errors on amd64

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried on arm64 and it fails with:

Step 1/11 : FROM golang:alpine AS builder
alpine: Pulling from library/golang
6e771e15690e: Pull complete
14aa1d43e92f: Pull complete
e18364ce0d25: Pull complete
4d476c939a05: Pull complete
4f4fb700ef54: Pull complete
Digest: sha256:2d40d4fc278dad38be0777d5e2a88a2c6dee51b0b29c97a764fc6c6a11ca893c
Status: Downloaded newer image for golang:alpine
 ---> d3f5bd625c1b
Step 2/11 : WORKDIR /src
 ---> Running in 6c0220b22067
 ---> Removed intermediate container 6c0220b22067
 ---> b7387e427a20
Step 3/11 : COPY go.* .
When using COPY with more than one source file, the destination must be a directory and end with a /

@efectn efectn merged commit 7af1480 into armbian:master Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants