Bugfix/json map full urls #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes JSON mapping to use only paths, preserving redirector functionality
- Fixes tests, removes excess debugging from tests
- Fixes khadas-vim4 and other images with a prefix before img.xz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the JSON mapping by removing the full URL scheme/host. By passing a full URL, we're simply pushing it to another redirector instance and ignoring the redirector's logic, which would require rewriting the redirection handler to efficiently handle.
This is the simpler of the two patches, as long as the server list is maintained on redirect.armbian.com as well as dl.armbian.com this will return the same results, without the extra redirect.