Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partition process: fix handling loop devices #7679

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jan 8, 2025

Description

When adding several improvements to the cryptoroot handling, we accidentally broke stability of handling loop devices. Partially reverting #7527 seems to be a solution.

@swissiety Check if there are no regression on the cryptoroot side.

How Has This Been Tested?

  • Build nightly images
  • Test one of the images on hardware

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from a team as a code owner January 8, 2025 10:49
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Jan 8, 2025
@igorpecovnik igorpecovnik changed the title Fix handling loop devices Images build: fix handling loop devices Jan 8, 2025
@igorpecovnik igorpecovnik changed the title Images build: fix handling loop devices Partition process: fix handling loop devices Jan 8, 2025
@igorpecovnik igorpecovnik added Bugfix Pull request is fixing a bug 02 Milestone: First quarter release Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jan 8, 2025
@igorpecovnik igorpecovnik merged commit 5cc3e2e into main Jan 8, 2025
14 checks passed
@igorpecovnik igorpecovnik deleted the loopdevfix branch January 8, 2025 12:17
@swissiety
Copy link
Contributor

  • builds with lvm, crypt, lvm+crypt

successful 1st boot on rock3a with:

  • lvm
  • crypt
  • lvm+crypt

"It works on my machine" ;-) thx for fixing it!

@igorpecovnik
Copy link
Member Author

It works on my machine

Good enough ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Bugfix Pull request is fixing a bug Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants