Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not enable BTF for rk35xx vendor kernel #7697

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

amazingfate
Copy link
Contributor

Description

I don't know why, after #7629 enabling BTF for rk35xx-vendor, bcmdhd dkms failed to load the module:

[  120.847047] dhd_static_buf_sdio: loading out-of-tree module taints kernel.
[  120.848769] Unable to handle kernel paging request at virtual address 00004021b00000c9
[  120.848785] Mem abort info:
[  120.848791]   ESR = 0x0000000096000004
[  120.848800]   EC = 0x25: DABT (current EL), IL = 32 bits
[  120.848811]   SET = 0, FnV = 0
[  120.848819]   EA = 0, S1PTW = 0
[  120.848826]   FSC = 0x04: level 0 translation fault
[  120.848835] Data abort info:
[  120.848840]   ISV = 0, ISS = 0x00000004
[  120.848847]   CM = 0, WnR = 0
[  120.848854] user pgtable: 4k pages, 48-bit VAs, pgdp=0000000139190000
[  120.848866] [00004021b00000c9] pgd=0000000000000000, p4d=0000000000000000
[  120.848888] Internal error: Oops: 0000000096000004 [#1] SMP
[  120.849402] Modules linked in: dhd_static_buf_sdio(O+) overlay rfcomm bnep zram zsmalloc binfmt_misc rtw88_8822ce hci_uart pwm_fan rk805_pwrkey rtw88_8822c btqca rtk_btusb rtw88_pci nvmem_rockchip_otp btusb rtw88_core btmtk btrtl btbcm btintel rockchip_cpuinfo input_leds joydev uio_pdrv_genirq uio fuse dm_mod ip_tables ipv6 panthor drm_gpuvm drm_exec drm_shmem_helper gpu_sched r8169
[  120.852529] CPU: 7 PID: 5372 Comm: modprobe Tainted: G           O       6.1.84-vendor-rk35xx #1
[  120.853321] Hardware name: Radxa ROCK 5B (DT)
[  120.853718] pstate: 80400009 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[  120.854349] pc : mod_sysfs_setup+0x230/0x518
[  120.854751] lr : mod_sysfs_setup+0x17c/0x518
[  120.855138] sp : ffff8000136f3b30
[  120.855437] x29: ffff8000136f3b30 x28: ffff80000ab1a910 x27: 0000000000000000
[  120.856083] x26: ffff800001387368 x25: ffff80000ab1a8a8 x24: ffff800001387090
[  120.856728] x23: ffff8000136f3d30 x22: ffff800001387058 x21: ffff800001385548
[  120.857371] x20: ffff800001387040 x19: 0000000000000000 x18: 0000000000000000
[  120.858015] x17: 68640074696e695f x16: 6675625f63697461 x15: 0000aaaab5980f70
[  120.858659] x14: 081e000000000000 x13: 006f6964735f6675 x12: 625f636974617473
[  120.859303] x11: fefefefefefefeff x10: 0000000000000000 x9 : ffff800009233b88
[  120.859947] x8 : 0101010101010101 x7 : 7f7f7f7f7f7f7f7f x6 : 6474706a716e7633
[  120.860591] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 0000000000000000
[  120.861234] x2 : ffff800001387058 x1 : ffff800001387090 x0 : 91004021b0000001
[  120.861878] Call trace:
[  120.862100]  mod_sysfs_setup+0x230/0x518
[  120.862460]  load_module+0x1870/0x1990
[  120.862803]  __do_sys_finit_module+0xf8/0x118
[  120.863201]  __arm64_sys_finit_module+0x24/0x30

From stacktrace kernel crashes at https://github.com/armbian/linux-rockchip/blob/rk-6.1-rkr4.1/kernel/module/sysfs.c#L395.

We can simplely skip this kernel when enabling BTF. I also tested mainline kernel 6.13-rc5, there is no such issue.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • ./compile.sh kernel BOARD=orangepi5-max BRANCH=vendor KERNEL_CONFIGURE=no

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels Jan 13, 2025
Copy link
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@rpardini rpardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I'll investigate it further down the line, but for now I see no other solution.

@amazingfate amazingfate merged commit e5b5e11 into armbian:main Jan 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants