Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nanopi R5S: proper pci phy reset - fixing missing LAN1 #7721

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

lanefu
Copy link
Member

@lanefu lanefu commented Jan 19, 2025

A change to Phy reset causes PCIE enumeration to not work properly. This makes LAN1 missing on the nanopi-r5s among another surprises. It impacts kernels 6.6.69+ and 6.12.8+

See discussion here https://lore.kernel.org/all/[email protected]/

This adds a patch from the mailing list https://lore.kernel.org/all/[email protected]/ that resolves the issue.

Tested on nanopi r5s 6.6.72 and 6.12.10

@lanefu lanefu requested a review from igorpecovnik as a code owner January 19, 2025 17:59
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jan 19, 2025
@rpardini
Copy link
Member

Nice, related to #7640 (that is the DT-fix)

@rpardini rpardini requested a review from amazingfate January 19, 2025 18:02
@igorpecovnik igorpecovnik changed the title use RK3568 phy fix from mailing list Nanopi R5S: proper pci phy reset - fixing missing LAN1 Jan 19, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release and removed Needs review Seeking for review labels Jan 19, 2025
@igorpecovnik igorpecovnik merged commit 53832cf into armbian:main Jan 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines
Development

Successfully merging this pull request may close these issues.

3 participants