Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meilleurs gestion des path dans le package #183

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Conversation

armgilles
Copy link
Owner

@armgilles armgilles commented Jan 8, 2025

  • Gestion plus élégantes des chemins d'accès pour les fichiers et model liées au package.
  • Permets de dev sur Linux et sur MacOS.

#182

@armgilles armgilles added the enhancement New feature or request label Jan 8, 2025
@armgilles armgilles self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.39%. Comparing base (6de5aa8) to head (d6130a2).

Files with missing lines Patch % Lines
src/vcub_keeper/config.py 52.94% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #183      +/-   ##
==========================================
- Coverage   68.70%   67.39%   -1.32%     
==========================================
  Files          10       10              
  Lines         310      319       +9     
==========================================
+ Hits          213      215       +2     
- Misses         97      104       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #183 will degrade performances by 9.32%

Comparing lib_install_mac (d6130a2) with dev (6de5aa8)

Summary

❌ 2 (👁 2) regressions
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark dev lib_install_mac Change
👁 test_benchmark_get_consecutive_no_transactions_out 2 ms 2.2 ms -9.32%
👁 test_benchmark_get_transaction_all 1.4 ms 1.5 ms -5.76%

@armgilles
Copy link
Owner Author

armgilles commented Jan 8, 2025

En dev :

pip install -e .
from vcub_keeper.config import ROOT_DIR
ROOT_DIR

# ROOT_DIR:  /Users/NAME/DIR/vcub_keeper
# PosixPath('/Users/NAME/DIR/vcub_keeper')

En prod :

pip install  .
from vcub_keeper.config import ROOT_DIR
ROOT_DIR

# ROOT_DIR:  /Users/NAME/miniforge3/envs/vcub_keeper_py312/lib/python3.12/site-packages/vcub_keeper
# In site-packages
# ROOT_DIR from environment variable:  /home/NAME_ENV/DIR/vcub_keeper
# ROOT_DIR from environment variable does not exist
# ROOT_DIR from cwd:  /Users/NAME/DIR/vcub_keeper
# '/Users/NAME/DIR/vcub_keeper'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant