add slack system test

[refaelm92]

Type

Tests

---

Description

This pull request introduces a system test for Slack notifications. The main changes include:

• Addition of a new test configuration for Slack alerts in notifications_tests.py.
• Addition of Slack-specific functions in alert_notifications.py to enrich Slack alert channel data and retrieve messages from a Slack channel.
• Refactoring of some existing functions in alert_notifications.py to support both Teams and Slack notifications.

---

PR changes walkthrough

	Relevant files
Tests	1 files notifications_tests.py                                                                            configurations/system/tests_cases/notifications_tests.py A new test configuration for Slack alerts has been added. This configuration uses the `AlertNotifications` test object and includes functions for retrieving messages from a Slack channel and enriching Slack alert channel data. +16/-0
Enhancement	1 files alert_notifications.py                                                                            tests_scripts/users_notifications/alert_notifications.py This file has been updated to include Slack-specific functions for enriching Slack alert channel data and retrieving messages from a Slack channel. Some existing functions have been refactored to support both Teams and Slack notifications. +41/-24

---

User description

Signed-off-by: refaelm [email protected]

[codiumai-pr-agent-free]

PR Description updated to latest commit (1cfae43)

[codiumai-pr-agent-free]

PR Analysis

(review updated until commit 1cfae43)

• 🎯 Main theme: Adding system tests for Slack notifications
• 📝 PR summary: This PR introduces a system test for Slack notifications. It includes the addition of a new test configuration for Slack alerts, Slack-specific functions to enrich Slack alert channel data and retrieve messages from a Slack channel, and refactoring of some existing functions to support both Teams and Slack notifications.
• 📌 Type of PR: Tests
• 🧪 Relevant tests added: Yes
• ⏱️ Estimated effort to review [1-5]: 3, because the PR involves changes in multiple files and introduces new functionalities. However, the code is well-structured and follows good practices, making it easier to understand.
• 🔒 Security concerns: No

PR Feedback

• 💡 General suggestions: The PR is well-structured and follows good practices. The addition of Slack notifications is a valuable feature. However, it would be beneficial to ensure that the environment variables used in the code are properly documented and securely stored.

• 🤖 Code feedback:

  ---

  relevant file	tests_scripts/users_notifications/alert_notifications.py
  suggestion	Consider handling the case where the SLACK_TOKEN or SLACK_CHANNEL_ID environment variables are not set. This could prevent potential runtime errors. [important]
  relevant line	client = WebClient(token=os.getenv("SLACK_TOKEN"))

  ---

  relevant file	tests_scripts/users_notifications/alert_notifications.py
  suggestion	It would be beneficial to add error handling for the API requests to ensure that the application can gracefully handle any potential failures. [medium]
  relevant line	result = client.conversations_history(channel=f'{os.getenv("SLACK_CHANNEL_ID")}', oldest=before_test)

  ---

  relevant file	configurations/system/tests_cases/notifications_tests.py
  suggestion	Consider refactoring the code to avoid the repetition of similar code blocks for different notification channels. This could improve the maintainability of the code. [medium]
  relevant line	def slack_alerts():

  ---

  relevant file	tests_scripts/users_notifications/alert_notifications.py
  suggestion	Consider refactoring the assert_all_messages_sent function to avoid the use of magic numbers. This could improve the readability of the code. [medium]
  relevant line	for i in range(5):

  ---

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.

[github-actions]

Persistent review updated to latest commit 1cfae43