Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable slack+teams tests to run on prod util we overcome the too man… #333

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

RinaO1234
Copy link
Contributor

@RinaO1234 RinaO1234 commented Apr 25, 2024

User description

…y requests issue that we faced with frontegg


Type

tests


Description

  • Temporarily disabled Slack and Teams alert channel tests on the production environment to address the issue of too many requests with Frontegg.

Changes walkthrough

Relevant files
Configuration changes
system_test_mapping.json
Disable Slack and Teams Tests on Production Environment   

system_test_mapping.json

  • Updated skip_on_environment for "teams_alerts" to "production"
  • Updated skip_on_environment for "slack_alerts" to "production"
  • +2/-2     

    PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    …y requests issue that we faced with frontegg
    Copy link

    PR Description updated to latest commit (2933b91)

    Copy link

    PR Review

    ⏱️ Estimated effort to review [1-5]

    1, because the PR involves simple configuration changes in a JSON file, specifically updating the "skip_on_environment" fields for two test configurations. The changes are straightforward and limited in scope, making the review process quick and easy.

    🧪 Relevant tests

    No

    🔍 Possible issues

    No

    🔒 Security concerns

    No


    ✨ Review tool usage guide:

    Overview:
    The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

    The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

    • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
    /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
    
    [pr_reviewer]
    some_config1=...
    some_config2=...
    

    See the review usage page for a comprehensive guide on using this tool.

    Copy link

    Failed to generate code suggestions for PR

    Copy link

    PR Code Suggestions

    CategorySuggestions                                                                                                                                                       
    Enhancement
    Modify the "skip_on_environment" field to use an array for better future flexibility.

    Consider using an array for "skip_on_environment" to allow flexibility in specifying
    multiple environments in the future without needing further schema changes.

    system_test_mapping.json [1149]

    -"skip_on_environment": "production"
    +"skip_on_environment": ["production"]
     
    Maintainability
    Verify that test execution logic is updated to respect the new "skip_on_environment" field.

    Ensure that the addition of "skip_on_environment" is accompanied by updates or checks in
    the test execution logic to respect this new field, preventing these tests from running in
    the specified environment.

    system_test_mapping.json [1149]

    -"skip_on_environment": "production"
    +"skip_on_environment": "production"  // Ensure test logic checks this field
     
    Documentation
    Add documentation for the "skip_on_environment" field to enhance clarity and maintainability.

    Add a comment or documentation in the JSON schema or related documentation to explain the
    purpose and usage of the "skip_on_environment" field for clarity and maintainability.

    system_test_mapping.json [1149]

    -"skip_on_environment": "production"
    +"skip_on_environment": "production"  // Used to exclude tests from running in specified environments
     

    ✨ Improve tool usage guide:

    Overview:
    The improve tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

    • When commenting, to edit configurations related to the improve tool (pr_code_suggestions section), use the following template:
    /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=...
    
    [pr_code_suggestions]
    some_config1=...
    some_config2=...
    

    See the improve usage page for a comprehensive guide on using this tool.

    @RinaO1234 RinaO1234 merged commit caca6fc into master Apr 25, 2024
    3 checks passed
    @RinaO1234 RinaO1234 deleted the disabletests-for-frontegg-issue branch April 25, 2024 15:32
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants