Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "enable test" #370

Closed
wants to merge 1 commit into from
Closed

Revert "enable test" #370

wants to merge 1 commit into from

Conversation

YiscahLevySilas1
Copy link
Contributor

@YiscahLevySilas1 YiscahLevySilas1 commented May 20, 2024

User description

Reverts #367


PR Type

configuration changes


Description

  • Reverted changes in system_test_mapping.json to replace repository names with their dummy counterparts.

Changes walkthrough 📝

Relevant files
Configuration changes
system_test_mapping.json
Revert repository names to dummy versions                               

system_test_mapping.json

  • Reverted changes to target_repositories field.
  • Replaced repository names with their dummy counterparts.
  • +4/-4     

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    Copy link

    PR Description updated to latest commit (02215fa)

    Copy link

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    1, because the changes are straightforward and only involve reverting repository names to their dummy counterparts in a JSON configuration file.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    No

    🔒 Security concerns

    No

    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Ensure repository names are correctly referenced for the intended environment

    Consider using consistent naming for the target repositories. The suffix '-dummy' might be
    used for testing or development purposes. If these entries are meant for production or
    main branches, ensure that the repository names are correctly referenced without the
    '-dummy' suffix.

    system_test_mapping.json [647-650]

    -"cadashboardbe-dummy",
    -"careportsreceiver-dummy",
    -"event-ingester-service-dummy",
    -"gateway-dummy"
    +"cadashboardbe",
    +"careportsreceiver",
    +"event-ingester-service",
    +"gateway"
     
    Suggestion importance[1-10]: 8

    Why: The suggestion correctly identifies a potential issue with the naming convention of the target repositories. If the '-dummy' suffix is meant for testing or development, it should be verified whether these entries are intended for production or main branches. This is important for maintaining consistency and avoiding confusion.

    8

    Copy link

    Failed to generate code suggestions for PR

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant