add method to extract some metadata from raw json #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirmalka
reviewed
Nov 16, 2023
| } | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| input, err := os.ReadFile(fmt.Sprintf("testdata/%s.json", tt.name)) |
There was a problem hiding this comment.
@matthyx I think you forgot to commit the testdata dir?
Signed-off-by: Matthias Bertschy <[email protected]>
|
Summary:
|
kooomix
requested changes
Nov 16, 2023
armometadata/k8sutils.go
Outdated
| @@ -102,3 +104,45 @@ func LoadConfig(configPath string) (*ClusterConfig, error) { | |||
| err = json.Unmarshal(res, &config) | |||
| return config, err | |||
| } | |||
|
|
|||
| // ExtractMetadataFromBytes extracts metadata from the JSON bytes of a Kubernetes object | |||
| func ExtractMetadataFromJsonBytes(input []byte) (error, map[string]string, map[string]string, string) { | |||
There was a problem hiding this comment.
@matthyx we need also ownerReferences and resourceVersion
amirmalka
approved these changes
Nov 16, 2023
Signed-off-by: Matthias Bertschy <[email protected]>
|
Summary:
|
kooomix
approved these changes
Nov 16, 2023
Signed-off-by: Matthias Bertschy <[email protected]>
|
Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.