Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not truncate wlid if namespace is empty, use string builder #12

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented Dec 8, 2023

No description provided.

@matthyx matthyx requested a review from dwertent December 8, 2023 07:35
Copy link

github-actions bot commented Dec 8, 2023

Summary:

  • License scan: failure
  • Credentials scan: skipped
  • Vulnerabilities scan: skipped
  • Unit test: success
  • Go linting: success

name: "cartservice",
},
want: "wlid://cluster-HipsterShopCluster2/namespace-/clusterrolebinding-cartservice",
// FIXME: do we want "wlid://cluster-HipsterShopCluster2/clusterrolebinding-cartservice" instead?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dwertent can you check this question?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the wlid format...

@dwertent dwertent merged commit fb8ffc6 into master Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants