[] accepts simple DOM elements

arnaudmolo · Feb 11, 2014 · ff0278a · ff0278a
1 parent da8cf09
commit ff0278a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -10,7 +10,7 @@ How To
 
 include the ```SmoothScroll``` in your application dependencies
 
-```SmoothScroll.$goTo(Number)``` return a promises resolved when the scroll is done
+```SmoothScroll.$goTo(param)``` return a promises resolved when the scroll is done
 
 ``
   var promise = SmoothScroll.$goTo(600);
@@ -32,6 +32,13 @@ include the ```SmoothScroll``` in your application dependencies
     return SmoothScroll.$goTo(200);
   });
 ```
+
+``$goTo`` accepts :
+  number
+  simple DOM element
+  angular element
+  selector
+
 ---------
 
 Next step:

diff --git a/build/ng-smoothscroll.js b/build/ng-smoothscroll.js
@@ -71,9 +71,12 @@
       return {
         $goTo: function(y, x) {
           var defer, _ref;
-          if ((_ref = y[0]) != null ? _ref.tagName : void 0) {
+          if (((_ref = y[0]) != null ? _ref.tagName : void 0) != null) {
             y = getElementTop(y[0]);
           }
+          if (y.tagName != null) {
+            y = getElementTop(y);
+          }
           if (typeof y === "string") {
             y = getElementTop(document.querySelector(y));
           }

diff --git a/build/ng-smoothscroll.min.js b/build/ng-smoothscroll.min.js
diff --git a/src/ng-smoothscroll.coffee b/src/ng-smoothscroll.coffee
@@ -53,8 +53,10 @@ angular.module("SmoothScroll", [])
 
     {
       $goTo: (y, x) ->
-        if y[0]?.tagName
+        if y[0]?.tagName?
           y = getElementTop y[0]
+        if y.tagName?
+          y = getElementTop y
         if typeof y is "string"
           y = getElementTop document.querySelector y
         defer = do $q.defer