-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [Data API] Backend refactoring #262
Open
roaffix
wants to merge
36
commits into
arrayfire:master
Choose a base branch
from
roaffix:feature/backend-refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithmetic operators
roaffix
changed the title
[WIP] Backend refactoring
[WIP] [Data API] Backend refactoring
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: the assumption that this PR will be merged right after the #261
Major changes:
safe_call(backend.get()...)
under thelibrary
call which is now used as a private wrapper of the C library. That makes the public part of the library more intuitive for both end-users and library contributors.ctypes
underCType
which inherits thectypes._SimpleCData
type.dtypes/helpers
. Also, some methods were transferred there from the array_object fileoperators
block which is duplicated the functionality of magic methods (like__add__
) from the main array object and is required by the specificationMinor changes:
ShapeType
to avoid extra complexion in library typing--- WIP ---
backend
config separated into pre-setup and backend configuration settingsoperators
tests
coverage