Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update the "imp" module to "importlib" #1187

Closed
wants to merge 1 commit into from
Closed

fix: update the "imp" module to "importlib" #1187

wants to merge 1 commit into from

Conversation

mlbright
Copy link

Fixes #1170

@dktrkranz
Copy link
Contributor

Changing the import is not enough, a complete patch can be found here: python/cpython@328cb1f#diff-27bf55510663a73d2fdea1e604efdb59e0115378530202b5c55d04656dedece2

arsenetar added a commit that referenced this pull request Feb 19, 2024
@arsenetar
fix: Replace use of imp with importlib
13dd00c 
Original PR and information found at #1187
@arsenetar
Copy link
Owner

This is fixed now, thanks.

@arsenetar arsenetar closed this Feb 19, 2024
@mlbright mlbright deleted the update-imp branch February 19, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hscommon\pygettext.py calling imp, which is removed in 3.12
3 participants
@mlbright @dktrkranz @arsenetar