Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jsx): handle falsy like React #861

Merged
merged 1 commit into from
Jun 7, 2024
Merged

feat(jsx): handle falsy like React #861

merged 1 commit into from
Jun 7, 2024

Conversation

kasperskei
Copy link
Contributor

@stackblitz StackBlitz
Copy link

stackblitz bot commented Jun 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel Vercel
Copy link

vercel bot commented Jun 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reatom ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 9:03pm

@kasperskei kasperskei force-pushed the 860-jsx-handle-falsy-like-react branch from 6ac9e60 to bbc228f Compare June 6, 2024 12:39
@kasperskei kasperskei force-pushed the 860-jsx-handle-falsy-like-react branch from bbc228f to 7308724 Compare June 6, 2024 13:03
BANOnotIT
BANOnotIT requested changes Jun 6, 2024
View reviewed changes
packages/jsx/src/index.test.tsx Outdated Show resolved Hide resolved
@kasperskei kasperskei force-pushed the 860-jsx-handle-falsy-like-react branch from 7308724 to 5cc44e2 Compare June 6, 2024 19:38
@kasperskei kasperskei force-pushed the 860-jsx-handle-falsy-like-react branch from 5cc44e2 to 6ae7fa6 Compare June 6, 2024 19:41
artalar
artalar requested changes Jun 6, 2024
View reviewed changes
packages/jsx/src/index.ts Outdated Show resolved Hide resolved
packages/jsx/src/jsx.d.ts Outdated Show resolved Hide resolved
packages/jsx/src/index.ts Outdated Show resolved Hide resolved
@kasperskei kasperskei force-pushed the 860-jsx-handle-falsy-like-react branch from 6ae7fa6 to 72b401b Compare June 6, 2024 21:02
@artalar artalar requested a review from BANOnotIT June 7, 2024 09:01
@artalar artalar merged commit ad52a74 into artalar:v3 Jun 7, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artalar artalar artalar approved these changes

@BANOnotIT BANOnotIT BANOnotIT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperskei @BANOnotIT @artalar