chore: migrate to vitest #948
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| Also, we use `onConnect` to fetch the list from the server every 5 seconds | ||
| and we don't want to call subscriptions extra times so we use `isDeepEqual` | ||
| in `withDataAtom` to prevent new reference stream if nothing really changed. | ||
| Also, we use onConnect to fetch the list from the server every 5 seconds |
| const INTERVAL = 5 | ||
|
|
||
| const getData = reatomAsync.from(api.getData).pipe( | ||
| // add `dataAtom` and map the effect payload into it |
| import { take, takeNested } from '@reatom/effects' | ||
| import { createTestCtx } from '@reatom/testing' | ||
| import { atom } from '@reatom/core' | ||
| import { mapToAsync, withDataAtom } from './index' | ||
|
|
||
| export const test = suite('mapToAsync') |
There was a problem hiding this comment.
There is no need to use describe, please change the tests runner script to this:
"test": "vitest run src/*.test.ts",
"test:watch": "vitest src/*.test.ts"
Understood, I just removed that one describe usage , changed the tests runner script and fixed the comments . Should I change the tests runner scripts to "test": "vitest run src/.test.ts", |
|
@caio2983 ive updated the deps and the async package tests, please check
yep |
|
@caio2983 Hi! Sorry for the delay, I have been super busy, working, sick and many other bus factor things :) Are you interested in continuing to work on this PR? I would love to merge it as soon as possible. |
| @@ -1,5 +1,4 @@ | |||
| import { test } from 'uvu' | |||
| import * as assert from 'uvu/assert' | |||
| import { describe, it, expect } from 'vitest' | |||
There was a problem hiding this comment.
btw, you can set up a global: true in vitest.config and this will allow you to remove all imports from 'vitest'
There was a problem hiding this comment.
imho direct import is more obvious.
|
consider to use a workspace feature in vitest which can be useful for monorepo such as reatom |
|
@artalar I can take over this and continue migration, do you mind? |
|
@AgarkovRoman ok, go ahead. |
#947
Hello @artalar ,
Please let me know if any changes need to be done in this