png: apng support #100
Closed
png: apng support #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libheif does not support animated avifs
Sync avifRGBImageAllocatePixels with github library version Signed-off-by: Zetrin0 <[email protected]>
В примере из официальной репы память в цикле выделяется, но не чистится, а указатель зануляется. Освобождаем в каждой итерации. Signed-off-by: Zetrin0 <[email protected]>
|
Набор для проверки |
|
Зачем тут коммиты про AVIF? И зачем их вообще так много? |
artemsen
requested changes
Dec 22, 2023
src/formats/png.c
Outdated
| // buffer must be black and transparent at start | ||
| memset(output_buffer, 0, buffer_size); | ||
|
|
||
| for (png_uint_32 volatile frame_num = 0; frame_num < num_frames; frame_num++) { |
src/formats/png.c
Outdated
| } | ||
| } | ||
|
|
||
| static int decode_png_frames(struct image* ctx, png_structp png, png_infop info) |
There was a problem hiding this comment.
Очень длинная функция, её бы на части разбить.
И код нужно пропустить через clang-format.
src/formats/png.c
Outdated
| free(ctx->frames[i].data); | ||
| } | ||
|
|
||
| tmp = realloc(ctx->frames, 1 * sizeof(*ctx->frames)); |
|
Извиняюсь, но я не знаю. Я не очень часто отправляю PR. Я думал, что PR смержится в один коммит. |
Нужно отребейзиться на текущий мастер и засквошить свои коммиты в один через |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Возможность просматривать анимированные PNG, если в системе пропатчена libpng.