Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable antialiasing while dragging #157

Closed
wants to merge 1 commit into from

Conversation

g-rden
Copy link
Contributor

@g-rden g-rden commented Jul 15, 2024

While the left mouse button is pressed down antialiasing is now disabled.

Reason: Dragging while antialiasing is enabled is unusable on some machines.

@artemsen
Copy link
Owner

This is a very extraordinary solution, but its implementation looks like a hack, especially "let's redraw on every mouse key event" =)
The main complaint is that the entire solution is based on the fact that ui_redraw() is a synchronous operation. This works now, but I plan to change the logic to event-driven model and ui_redraw will be called asynchronously.
So, even if we merge this PR, this solution will not survive to release.

@g-rden
Copy link
Contributor Author

g-rden commented Jul 16, 2024

very extraordinary solution

lol, yeah I am no programmer.

"let's redraw on every mouse key event"

That is not happening. It only gets drawn when the mouse button is first pressed down and then when it is released again.

this solution will not survive to release.

Fair.

@g-rden g-rden closed this Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants