Sanitizer #172
Merged
Sanitizer #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes src/loader.c:303:1: warning: leak of file descriptor ‘pfd[1]’ Signed-off-by: Alexandr Pashchenko <[email protected]>
Fixes src/application.c:383:1 A part of conditional expression is always true: first_image Signed-off-by: Alexandr Pashchenko <[email protected]>
Fixes src/config.c:117:27: warning: leak of ‘section’ Signed-off-by: Alexandr Pashchenko <[email protected]>
Signed-off-by: Alexandr Pashchenko <[email protected]>
Fixes src/info.c:99:5: warning: use of possibly-NULL ‘ctx.scheme[0][1].fields’ where non-null expected Signed-off-by: Alexandr Pashchenko <[email protected]>
Fixes src/str.c:65:9: warning: check of ‘text’ for NULL after already dereferencing it Signed-off-by: Alexandr Pashchenko <[email protected]>
Fixes src/viewer.c:260 'ui_get_width()' was implicitly cast from 'size_t' type to 'double' Signed-off-by: Alexandr Pashchenko <[email protected]>
artemsen
reviewed
Aug 4, 2024
|
Видимо не выспался =) Да, тут всё норм.
…On Sun, Aug 4, 2024, 19:04 Zetrin0 ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/application.c
<#172 (comment)>:
> @@ -380,9 +380,8 @@ bool app_init(const char** sources, size_t num)
}
if (ctx.window.width == SIZE_FULLSCREEN) {
ui_toggle_fullscreen();
- } else if (first_image &&
Артём, вы не выспались, или я что-то не понимаю?
Коммит наоборот *убирает* эту переменную из условия.
—
Reply to this email directly, view it on GitHub
<#172 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAI5UOF6R3IFPTJWMNJR4MLZPZGJLAVCNFSM6AAAAABL6WU2CWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJXG44DAMBUGA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Fixes runtime error: left shift of X by Y places cannot be represented in type 'int' Signed-off-by: Alexandr Pashchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various problems found by sanitizer.