feat: storing thumbnails on disk #201
Conversation
Rentib
force-pushed
the
cache_thumbnails_on_disk
branch
from
e142daa
to
f51c6e5
Compare
src/pixmap.c
Outdated
| return false; | ||
| } | ||
|
|
||
| // TODO: add alpha channel |
There was a problem hiding this comment.
We have 14 supported image formats. It would be better to use one of them instead of reinventing own format.
There was a problem hiding this comment.
I don't see any function for writing an image to disk in the codebase. Did I miss something?
There was a problem hiding this comment.
Current code doesn't contain code for encoders. But these APIs are available to swayimg.
There was a problem hiding this comment.
Is it fine to keep current ppm format or should I change it?
There was a problem hiding this comment.
I think it would be better to add encode_pnm to PNM(PPM) decoder.
Rentib
force-pushed
the
cache_thumbnails_on_disk
branch
4 times, most recently
from
8f74942
to
25fa0e2
Compare
Rentib
force-pushed
the
cache_thumbnails_on_disk
branch
from
a174ef2
to
ad5f58f
Compare
|
Please, rebase to latest master. This will fix Ubuntu CI (but this doesn't resolve the warnings you have =). |
Rentib
force-pushed
the
cache_thumbnails_on_disk
branch
from
d39131f
to
f3ad6a7
Compare
| return true; | ||
| } | ||
|
|
||
| static bool get_thumb_path(char** path, const char* source) |
There was a problem hiding this comment.
static chat* get_thumb_path(const char* source) would be clearer.
Bu the way, source can contain prefix exec:// or starts with ../../../../../../etc/passwd, so which path you finally create?
There was a problem hiding this comment.
Ok, this is a problem. I will fix it to not pass source, but the absolute file path.
| struct thumbnail_params params; | ||
|
|
||
| /* TODO: move to config */ | ||
| bool thumbnails_disk_cache = false; |
There was a problem hiding this comment.
I think it should be a part of the static context for the thumbnail entity.
Rentib
force-pushed
the
cache_thumbnails_on_disk
branch
3 times, most recently
from
2ef0a74
to
88f2d10
Compare
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
refactor: format code Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
breaking change: image_thumbnail() takes arguments Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Signed-off-by: Rentib <[email protected]>
Closes #200