This repository has been archived by the owner on Dec 27, 2023. It is now read-only.
Added etcd storage #306
Merged
Added etcd storage #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olenagerasimova
suggested changes
Apr 20, 2021
| return new Concatenation(content).single() | ||
| .map(buf -> new Remaining(buf).bytes()) | ||
| .map(bytes -> ByteSequence.from(bytes)) | ||
| .to(SingleInterop.get()) |
There was a problem hiding this comment.
@g4s8 you can simply use PublisherAs() here to read all bytes from content
|
|
||
| @Override | ||
| public CompletableFuture<Void> delete(final Key key) { | ||
| return this.client.getKVClient().delete(keyToSeq(key)).thenApply(ignore -> (Void) null); |
There was a problem hiding this comment.
@g4s8 hm, will this method fail if key does not exist? It should according to Storage contract
For #305 - introduced etcd storage, added integration test using junit extension.
|
@olenagerasimova thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #305 - introduced etcd storage, added integration test
using junit extension.