Docker upload benchmark #19
Conversation
|
@g4s8, can you review the Pull Request? |
There was a problem hiding this comment.
@Sammers21 please keep synthetic benchmarks and client based benchmarks in separate directories. Also, please add a script to run these benchmark on existing AWS infrastructure and publish reports to HTML
@g4s8, this Pull Request does not contain any synthetic benchmarks. It is a topic for future work. |
@g4s8, Can I please do it in a separated request? |
@g4s8, please pay attention that reports are going to be published in JSON in order to be visualised with Chats.js. |
|
@g4s8, review the pull request, please. |
| for IP in $PUBLIC_SERVER_IP_ADDR $PUBLIC_CLIENT_IP_ADDR | ||
| do | ||
| ssh -i aws_ssh_key -oStrictHostKeyChecking=no ubuntu@$IP <<'ENDSSH' | ||
| set -x |
There was a problem hiding this comment.
@Sammers21 don't we need set -e here too?
docker/upload.py
Outdated
| f = open("./artipie.yaml", "w+") | ||
| f.write(artipie_yml) | ||
| f.close() |
There was a problem hiding this comment.
@Sammers21 it could be wrapped in with construct to close resource properly (similar to try-with-resources in Java):
with open('./artipie.yaml', 'w+') as f:
f.write(artipie_yml)
docker/upload.py
Outdated
| f = open("./configs/my-docker.yaml", "w+") | ||
| f.write(my_docker) | ||
| f.close() |
| artipie_yml = """ | ||
| meta: | ||
| storage: | ||
| type: fs | ||
| path: /var/artipie/configs | ||
| layout: flat | ||
| """ | ||
| my_docker = """ | ||
| repo: | ||
| type: docker | ||
| storage: | ||
| type: fs | ||
| path: /var/artipie/data | ||
| permissions: | ||
| "*": | ||
| - "*" | ||
| """ |
There was a problem hiding this comment.
@Sammers21 these variables seems to be constants, and could be moved out of function's scope
There was a problem hiding this comment.
@g4s8, why? The only place they seem to be relevantly located is the function body where they are located now.
The script measures single docker upload performance of Artipie and docker registry, the script writes results into
docker.jsonfile which can be used for visualisation on Github Pages.Related to #18