chore: New feature flag for artwork card long press menu on iOS #11398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olerichter00
force-pushed
the
olerichter00/ONYX-1490/new-feature-flag-for-artwork-card-long-press-menu-on-ios
branch
from
658e6cf to
bc3116b
Compare
olerichter00
added
the
Squash On Green
olerichter00
commented
Jan 15, 2025
| @@ -258,6 +246,12 @@ export const features = { | |||
| showInDevMenu: true, | |||
| echoFlagKey: "AREnableViewPortPrefetching", | |||
| }, | |||
| AREnableArtworkCardContextMenuIOS: { | |||
| description: "Enable long press menu on artwork cards for iOS", | |||
| readyForRelease: true, | |||
There was a problem hiding this comment.
All lunch-blocking bugs are addressed, so setting readyForRelease to true.
olerichter00
commented
Jan 15, 2025
Comment on lines
-86
to
-89
| const enableContextMenuForRecommendations = | ||
| useFeatureFlag("AREnableLongPressOnNewForYouRail") && contextModule == "newWorksForYouRail" | ||
| const enableContextMenu = | ||
| useFeatureFlag("AREnableLongPressOnArtworkCards") || enableContextMenuForRecommendations |
There was a problem hiding this comment.
Getting rid of these two feature flags in favor of just one that enables and disables the long-press context menu on artwork items.
|
Merging this PR to have it in tomorrows beta for the QA session. |
artsy-peril
bot
deleted the
olerichter00/ONYX-1490/new-feature-flag-for-artwork-card-long-press-menu-on-ios
branch
|
Sorry, didn't review on time. Thanks for the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves ONYX-1490
artsy/echo#757
Description
Creating a new feature flag for the artwork card long press menu on iOS because the old one is enabled for app versions that contain bugs. Simply enabling the old feature flags in Echo would also enable the feature for the buggy app versions.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.