feat(EMI-2187): Refresh Bids screen every 10 secs #11407
Conversation
MrSltun
requested review from
starsirius,
leamotta,
erikdstock and
rquartararo
There was a problem hiding this comment.
This approach is totally fine, but heads up that we use this usePoll hook throughout a few of our codebases. Might be nice to add here as well: https://github.com/artsy/force/blob/main/src/Utils/Hooks/usePoll.ts
|
@damassi I saw that A good Future Friday project idea would be to consolidate them into one across our codebases :) |
src/app/Scenes/MyBids/MyBids.tsx
Outdated
| relay.refetch( | ||
| {}, | ||
| null, | ||
| (error) => { | ||
| if (error) { | ||
| console.error("MyBids/index.tsx #refreshMyBids", error.message) | ||
| // FIXME: Handle error | ||
| } | ||
| setIsFetching(false) | ||
| }, | ||
| { force: true } | ||
| ) | ||
| } |
There was a problem hiding this comment.
minor: If we aren't going to handle it explicitly, could we send to sentry or otherwise know how often this happens?
There was a problem hiding this comment.
Great idea! I'll add that
| } | ||
|
|
||
| useAppState({ | ||
| onChange: (state) => { | ||
| setAppIsInForeground(state === "active") |
There was a problem hiding this comment.
non-blocking: should "active" be constantized/enumized?
There was a problem hiding this comment.
I think since it's typed, it's okay to leave it as is?
|
Ah! Sorry @MrSltun - i read |
MrSltun
force-pushed
the
mrsltun/EMI-2187/refreshing-Bids-screen
branch
from
b95554e to
8f4bb1b
Compare
This PR resolves EMI-2187
Description
This PR implements a
useIntervalin the Bids screen to update it every 10 secondsPR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.