Skip to content

Commit

Permalink
fix: reduced code complexity
Browse files Browse the repository at this point in the history
  • Loading branch information
RealAnna authored and arttor committed Feb 15, 2023
1 parent 467bab4 commit 5b663ea
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions pkg/processor/deployment/deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ func processPodContainer(name string, appMeta helmify.AppMetadata, c corev1.Cont
return c, errors.Wrap(err, "unable to set deployment value field")
}

c, err = processEnv(name, appMeta, c, values, containerName)
c, err = processEnv(name, appMeta, c, values)
if err != nil {
return c, err
}
Expand Down Expand Up @@ -280,7 +280,8 @@ func processPodContainer(name string, appMeta helmify.AppMetadata, c corev1.Cont
return c, nil
}

func processEnv(name string, appMeta helmify.AppMetadata, c corev1.Container, values *helmify.Values, containerName string) (corev1.Container, error) {
func processEnv(name string, appMeta helmify.AppMetadata, c corev1.Container, values *helmify.Values) (corev1.Container, error) {
containerName := strcase.ToLowerCamel(c.Name)
for i := 0; i < len(c.Env); i++ {
if c.Env[i].ValueFrom != nil && c.Env[i].ValueFrom.SecretKeyRef != nil {
c.Env[i].ValueFrom.SecretKeyRef.Name = appMeta.TemplatedName(c.Env[i].ValueFrom.SecretKeyRef.Name)
Expand Down

0 comments on commit 5b663ea

Please sign in to comment.