Sanitize ?s in words/labels
#1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drkameleon
added
parser
github-actions
bot
removed
the
parser
github-actions
bot
added
vm
|
Ready to merge! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Question marks, by convention or not, are meant to add some variant of an existing symbol; or simply denote a predicate (= function that returns a Logical value).
That being said, the only place where this would make sense would be at the very end of a word. (e.g.
something?). Anything else should be disallowed. And, of course, we shouldn't allow more than one?within a word - yes, believe it or not this is absolutely a Word right now:something?anotherone??.Let's start untangling this mess.
Type of change