chore: Refactor type hinting in BaseBackend and its subclasses #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `TypeVar` and `Generic` to define a generic type `T` in `BaseBackend`. - Apply the generic type `T` to methods and attributes in `BaseBackend`. - Update `Win32Backend` and `UnixLikeBackend` to specify the type for `T`. - Reduce repetition of type hinting in constructors and method return types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeVarandGenericto define a generic typeTinBaseBackend.Tto methods and attributes inBaseBackend.Win32BackendandUnixLikeBackendto specify the type forT.This pull request includes several changes to the
blinkstickbackends to improve type annotations and ensure type consistency across different backends. The most important changes include introducing generics to theBaseBackendclass, updating method return types, and adding type ignores for certain imports.Improvements to type annotations and consistency:
src/blinkstick/backends/base.py: Introduced generics to theBaseBackendclass and updated method return types to use the new generic typeT. [1] [2]src/blinkstick/backends/unix_like.py: Updated theUnixLikeBackendclass to use theusb.core.Devicetype for the generic parameterTand updated method return types accordingly. [1] [2] [3]src/blinkstick/backends/win32.py: Updated theWin32Backendclass to use thehid.HidDevicetype for the generic parameterT, added type annotations for class attributes, and updated method return types accordingly. [1] [2] [3]src/blinkstick/backends/unix_like.pyandsrc/blinkstick/backends/win32.py: Added# type: ignorecomments to suppress type checking forusbandpywinusbimports. [1] [2]src/blinkstick/blinkstick.py: Improved thefind_allmethod to handle cases where no devices are found by using a more concise and type-safe approach.