cleanup: fix latest nightly lint warnings #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cargo clippy` was failing in this CI run: https://github.com/arxanas/git-branchless/actions/runs/12127041277?pr=1460 Actually, I have no idea how it even resulted in this. If I understand correctly, `cfg(test)` shouldn't even be enabled here, so the `testing` module shouldn't even be checked. I was unable to reproduce the issue locally on `1.74.1` and `nightly`. Possibly it's something non-deterministic that depends on the order that crates were compiled, or some other caching issue. Regardless, it seems fine to add the doc-comments, so I've added them and now hope that CI will pass.
arxanas
force-pushed
the
arxanas/cleanup
branch
from
9679631 to
d692c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.