Update PathProtocResolver.java to ignore executable bit on Windows

ascopes · Oct 23, 2023 · 36e41eb · 36e41eb
1 parent 49aafe6
commit 36e41eb
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/main/java/io/github/ascopes/protobufmavenplugin/resolver/PathProtocResolver.java b/src/main/java/io/github/ascopes/protobufmavenplugin/resolver/PathProtocResolver.java
@@ -65,7 +65,7 @@ public Path resolveProtoc() throws ProtocResolutionException {
 
         try (var fileStream = Files.list(indexableDirectory)) {
           var result = fileStream
-              .filter(Files::isExecutable)
+              .filter(this::isExecutable)
               .filter(this::isProtoc)
               .findFirst();
 
@@ -83,6 +83,11 @@ public Path resolveProtoc() throws ProtocResolutionException {
     }
   }
 
+  private boolean isExecutable(Path path) {
+    // TODO(ascopes): Verify this is the correct logic...
+    return HostEnvironment.isWindows() || Files.isExecutable(path);
+  }
+
   private boolean isProtoc(Path path) {
     var fileName = path.getFileName().toString();