Merge pull request #21 from ascopes/feature/GH-20-remove-deterministi…

…c-output GH-20: Remove deterministic output functionality
ascopes · Nov 25, 2023 · 961ceaa · 961ceaa
2 parents 4c8d4ed + 88e218c
commit 961ceaa
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 30 deletions.
diff --git a/src/main/java/io/github/ascopes/protobufmavenplugin/AbstractGenerateMojo.java b/src/main/java/io/github/ascopes/protobufmavenplugin/AbstractGenerateMojo.java
@@ -60,7 +60,6 @@ public abstract class AbstractGenerateMojo extends AbstractMojo {
   private Set<Path> sourceDirectories;
   private Path outputDirectory;
   private Boolean fatalWarnings;
-  private Boolean reproducibleBuilds;
 
   /**
    * Initialise this Mojo.
@@ -72,7 +71,6 @@ protected AbstractGenerateMojo() {
     sourceDirectories = null;
     outputDirectory = null;
     fatalWarnings = null;
-    reproducibleBuilds = null;
   }
 
   /**
@@ -144,18 +142,6 @@ public final void setFatalWarnings(boolean fatalWarnings) {
     this.fatalWarnings = fatalWarnings;
   }
 
-  /**
-   * Request that {@code protoc} should try to keep things like map ordering consistent between
-   * builds while a consistent version of {@code protoc} is in use.
-   *
-   * @param reproducibleBuilds whether to enable reproducible builds or not.
-   * @since 0.0.1
-   */
-  @Parameter(defaultValue = "false")
-  public final void setReproducibleBuilds(boolean reproducibleBuilds) {
-    this.reproducibleBuilds = reproducibleBuilds;
-  }
-
   /**
    * Execute this goal.
    *
@@ -172,7 +158,6 @@ public final void execute() throws MojoExecutionException, MojoFailureException
     registerSource(mavenSession.getCurrentProject(), outputDirectory);
 
     var compilerExecutor = new ProtocExecutorBuilder(protocPath)
-        .deterministicOutput(reproducibleBuilds)
         .fatalWarnings(fatalWarnings)
         .includeDirectories(sourceDirectories)
         .outputDirectory(getSourceOutputType(), outputDirectory)

diff --git a/src/main/java/io/github/ascopes/protobufmavenplugin/execute/ProtocExecutorBuilder.java b/src/main/java/io/github/ascopes/protobufmavenplugin/execute/ProtocExecutorBuilder.java
@@ -70,21 +70,6 @@ public ProtocExecutorBuilder outputDirectory(String outputType, Path outputDirec
     return this;
   }
 
-  /**
-   * Enable/disable deterministic output.
-   *
-   * <p>Calling this more than once is undefined behaviour.
-   *
-   * @param deterministicOutput whether to enable deterministic output or not.
-   * @return this builder.
-   */
-  public ProtocExecutorBuilder deterministicOutput(boolean deterministicOutput) {
-    if (deterministicOutput) {
-      arguments.add("--deterministic_output");
-    }
-    return this;
-  }
-
   /**
    * Enable/disable fatal warnings.
    *