GH-132: Fix race condition when referencing the same archived dependencies in multiple places #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncies in multiple places
…at are duplicated
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 83.17% 83.21% +0.05%
==========================================
Files 23 23
Lines 778 780 +2
Branches 49 49
==========================================
+ Hits 647 649 +2
Misses 110 110
Partials 21 21
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GH-132.
Repeated dependencies are not currently de-duplicated from the classpath which leads to concurrency issues from race conditions when unpacking the same path in multiple places.
This also now deals with normalizing paths to ensure that they are handled consistently and only once even if using relative/non-normalised path patterns.