Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure unified artifact coordinate type. #136

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Mar 22, 2024

This replaces the use of DependableCoordinate and ArtifactCoordinate outside a couple of locations that depend on the artifact resolver API as implementation detail. This will allow for adjusting the internal implementation later much more easily going forwards.

The use of .setExtension on the artifact/dependency types used for parameters is now deprecated and should be replaced with .setType instead. This will be removed in v2.0.0.

While this is technically a breaking change in the code itself, the new parameter type remains fully compatible with the current parameter type, so this is not a major version bump. Users should not see any difference in the API signature when using Maven XML to configure it.

This replaces the use of DependableCoordinate and ArtifactCoordinate
outside a couple of locations that depend on the artifact resolver
API as implementation detail. This will allow for adjusting the
internal implementation later much more easily going forwards.

The use of .setExtension on the artifact/dependency types used for
parameters is now deprecated and should be replaced with .setType
instead. This will be removed in v2.0.0.
@ascopes ascopes added the new feature A new user-facing feature. label Mar 22, 2024
@ascopes ascopes self-assigned this Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 83.95062% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 82.67%. Comparing base (f4a9b04) to head (fefe0c7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
- Coverage   83.21%   82.67%   -0.54%     
==========================================
  Files          23       24       +1     
  Lines         780      819      +39     
  Branches       49       54       +5     
==========================================
+ Hits          649      677      +28     
- Misses        110      122      +12     
+ Partials       21       20       -1     
Files Coverage Δ
...opes/protobufmavenplugin/AbstractGenerateMojo.java 81.97% <ø> (ø)
...ufmavenplugin/dependency/BinaryPluginResolver.java 87.18% <100.00%> (+1.82%) ⬆️
...tobufmavenplugin/dependency/JvmPluginResolver.java 85.42% <100.00%> (-1.62%) ⬇️
...avenplugin/dependency/PlatformArtifactFactory.java 100.00% <100.00%> (ø)
...protobufmavenplugin/dependency/ProtocResolver.java 76.93% <100.00%> (ø)
...plugin/dependency/MavenDependencyPathResolver.java 87.88% <91.67%> (-1.86%) ⬇️
.../protobufmavenplugin/dependency/MavenArtifact.java 77.36% <77.36%> (ø)

@ascopes ascopes merged commit 24523f5 into main Mar 22, 2024
15 checks passed
@ascopes ascopes deleted the task/unified-artifact-coordinate branch March 22, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new user-facing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant