Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not pass missing default source directory to protoc #178

Closed
wants to merge 2 commits into from
Closed

Do not pass missing default source directory to protoc #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e386cf
Do not pass missing default source directory to protoc
ascopes Apr 21, 2024
6b613fa
Fix typo
ascopes Apr 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...aven-plugin/src/main/java/io/github/ascopes/protobufmavenplugin/AbstractGenerateMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import java.io.File;
import java.io.IOException;
import java.net.URL;
import java.nio.file.Files;
import java.nio.file.Path;
import java.util.Collection;
import java.util.List;
Expand Down Expand Up @@ -578,7 +579,12 @@ private Path outputDirectory() {

private Collection<Path> sourceDirectories() {
if (sourceDirectories == null || sourceDirectories.isEmpty()) {
return List.of(defaultSourceDirectory());
var defaultSourceDirectory = defaultSourceDirectory();
// Don't bother injecting the default source directory if it doesn't exist. Let the
// plugin error instead.
return Files.exists(defaultSourceDirectory)
? List.of(defaultSourceDirectory)
: List.of();
}

return sourceDirectories.stream()
Expand Down
Loading